From 83318d7e738de56e7b436aec0bdfd86e3fff58ea Mon Sep 17 00:00:00 2001 From: Eric Teunis de Boone Date: Thu, 9 Jul 2020 16:57:17 +0200 Subject: [PATCH] Ex7.4 feedback: change _s pointer to member attribute --- ex7.4/Stack.hh | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/ex7.4/Stack.hh b/ex7.4/Stack.hh index e4f3fa1..07ceaa4 100644 --- a/ex7.4/Stack.hh +++ b/ex7.4/Stack.hh @@ -8,18 +8,11 @@ template class Stack { // Interface public: - Stack() { - _s = new std::deque(); - } - ~Stack() { - delete _s; - } - - int nitems() { return _s->size() ; } - bool empty() { return (_s->size() == 0) ; } + int nitems() { return _s.size() ; } + bool empty() { return (_s.size() == 0) ; } void push(T c) { - _s->push_back(c); + _s.push_back(c); } T pop() { @@ -28,15 +21,15 @@ class Stack { return 0 ; } - T tmp = _s->back(); - _s->pop_back(); + T tmp = _s.back(); + _s.pop_back(); return tmp; } void inspect() { - for ( auto iter = _s->begin(); iter != _s->end() ; iter++ ) + for ( auto iter = _s.begin(); iter != _s.end() ; iter++ ) { std::cout << *iter << std::endl; } @@ -44,7 +37,7 @@ class Stack { // Implementation private: - std::deque* _s ; + std::deque _s ; }; #endif